style(context_bar): add space between bar and percentage#179
Merged
Conversation
The rendered context bar previously printed the percentage directly adjacent to the trailing empty character (e.g. `███░░░░░░░35%`), which looked cramped — especially with `░` shading next to digits. Insert a single space so the output reads `███░░░░░░░ 35%`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
Owner
|
Merged! Thank you for your submission. Will release a new version over the weekend |
yonas
pushed a commit
to yonasBSD/cship
that referenced
this pull request
May 13, 2026
- Bump crate version to 1.7.1 and unify the tagline across crate description, README hero, and docs/index.md hero - Center the README title block (heading, badges, tagline, hero image) via `<div align="center">` - Showcase: drop the redundant "Full Starship Prompt" example and fold the Catppuccin Powerline `starship.toml` into the Hero example, labelled alongside `~/.config/cship.toml` - Refresh example screenshots - Include stephenleo#179's space-between-bar-and-percentage `context_bar` fix in the release notes Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
███░░░░░░░ 35%instead of███░░░░░░░35%.Why
With the default empty character
░(light shade) sitting flush against a digit, the percentage looks visually cramped. A single space cleanly separates the bar from the number without affecting width-sensitive consumers (the bar width itself is unchanged; only one extra space is appended before the percentage text).Test plan
cargo fmtcargo clippy -- -D warningscargo test— 68 passed, 0 failed (includingtest_context_bar_35_percent_3_filled_7_empty, which asserts on filled/empty char counts and the"35%"substring — both still hold)cargo build --release🤖 Generated with Claude Code