test: fix re-use existing authClient test#23
Merged
stephenplusplus merged 4 commits intostephenplusplus:masterfrom Jul 26, 2017
Merged
test: fix re-use existing authClient test#23stephenplusplus merged 4 commits intostephenplusplus:masterfrom
stephenplusplus merged 4 commits intostephenplusplus:masterfrom
Conversation
I believe this got broken by stephenplusplus#21.
Owner
|
Can you explain more how this was broken? It also doesn't seem like the test that's been changed is still testing what it says it is (re-using a cached auth client). |
Collaborator
Author
|
With #21, if an |
Owner
|
Is this line tested anywhere? Line 111 in ac4daa6 |
Collaborator
Author
|
Not only was that line untested, it was unreachable. PTAL. |
Collaborator
Author
|
Actually it still might benefit from an additional test. Adding. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this got broken by #21.