Skip to content

test: fix re-use existing authClient test#23

Merged
stephenplusplus merged 4 commits intostephenplusplus:masterfrom
ofrobots:fix-tests
Jul 26, 2017
Merged

test: fix re-use existing authClient test#23
stephenplusplus merged 4 commits intostephenplusplus:masterfrom
ofrobots:fix-tests

Conversation

@ofrobots
Copy link
Copy Markdown
Collaborator

I believe this got broken by #21.

@stephenplusplus
Copy link
Copy Markdown
Owner

Can you explain more how this was broken? It also doesn't seem like the test that's been changed is still testing what it says it is (re-using a cached auth client).

@ofrobots
Copy link
Copy Markdown
Collaborator Author

With #21, if an authClient exists, we simply return it. The test was mocking authClient but and expecting authClientPromise would resolve to the mocked value of authClient.

@stephenplusplus
Copy link
Copy Markdown
Owner

Is this line tested anywhere?

this.authClientPromise = Promise.resolve(this.authClient);

@ofrobots
Copy link
Copy Markdown
Collaborator Author

Not only was that line untested, it was unreachable. PTAL.

@ofrobots
Copy link
Copy Markdown
Collaborator Author

Actually it still might benefit from an additional test. Adding.

@stephenplusplus stephenplusplus merged commit 3402be3 into stephenplusplus:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants