[WIP] Fallthrough statement support #11
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds _basic_ support for attribute specifier sequences. They can have extra syntax (e.g. namespaces indicating the compiler attributes are available in) but right now we don't bother with that and treat them as attributes within double square brackets, which seems to suffice for e.g. GNUTLS.
There's a new statement from C17 --- `[[fallthrough]]` --- which we don't support yet. GNUTLS uses it. It seems a little redundant to me? Seemingly it's supposed to indicate to the compiler that fallthrough really is expected somewhere. This adds it as a new type of statement, albeit with some hacky bits in the lexer.
Owner
|
Thanks Tom. Just to help my understanding: Just out of interest, can you point me at some gnutls code where this is used? I am curious to see whether they have guarded it on C23 support. If they are using it unguardedly, that seems very bleeding-edge for such a widely-used package. If they have a guard, we might want to make use of it rather than get dragged into C23 support when other things may be more pressing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's such a thing as a "fallthrough statement", which GNUTLS also uses. This implementation has a couple of issues so it's very much WIP...:
[[fallthrough]]as an attribute, which should be allowed too, but currently[[fallthrough]]must be a "fallthrough statement"[[fallthrough]],[[FALLTHROUGH]],[[__fallthrough__]]), so I need to revisit and remove the invalid formsBit of a strange one but GNUTLS wanted it. Progress progress.