Open
Conversation
Statistics toolbox.
Member
Author
|
I also added a startup.m file which I use to load the required MATLAB functions (e.g., lightspeed), but feel free to remove this. |
Collaborator
|
Hi Peter, Thanks! I have a few comments on the changes. Please let me know whether they looks good to you, and then I will merge this pull request immediately.
Once I merge this pull request, I will add two unit tests: |
Member
Author
|
Xiang, that all sounds great to me. Also, I forgot to mention this before, but please do not delete the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Xiang,
Can you please review & accept my pull request, making modifications as you see fit?
I successfully completed a run of example1.m on the PPS cluster. Here is a summary of the results I obtained:
Main changes:
pctfilewithpercentile.unidrndwithrandint.example1.mto specify where the data and results are stored.Let me know if you have any questions or need any assistance with this pull request.
Thanks,
Peter