feat: Add WriteAsync support (#104)

[BenjiAtTrystar]

See #104

This is a possible way to implement some of the WriteAsync methods on TextWriter.

[gemini-code-assist]

Summary of Changes

Hello @BenjiAtTrystar, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the CsvWriter class by integrating comprehensive asynchronous writing capabilities. The primary goal is to allow for non-blocking I/O operations when writing CSV data to a TextWriter, which is crucial for applications requiring high responsiveness or handling large datasets. This is achieved through the addition of new WriteAsync methods and the conversion of internal line-writing logic to an asynchronous pattern, ensuring that all write operations can be performed without blocking the calling thread.

Highlights

• Asynchronous CSV Writing: A new public static async Task WriteAsync method has been added to CsvWriter to support asynchronous writing of CSV data from an IEnumerable<string[]>.
• Asynchronous Line Handling: An internal private static async Task WriteLineAsync method was introduced, mirroring the synchronous WriteLine logic but performing I/O operations asynchronously.
• Integration of Async Operations: Existing asynchronous WriteAsync methods (specifically the one handling IAsyncEnumerable) have been updated to leverage the new await WriteLineAsync for all line-by-line writing, ensuring full asynchronous execution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces asynchronous writing capabilities for IEnumerable<string[]> and refactors existing asynchronous methods to utilize a new WriteLineAsync helper. The implementation is sound, but I've provided a few suggestions to enhance code clarity, maintainability, and performance. My feedback includes recommendations for simplifying loop structures in the WriteAsync methods for better readability, addressing a potential performance bottleneck in WriteLineAsync related to string allocations, and correcting some formatting inconsistencies.

[gemini-code-assist]

There appears to be inconsistent indentation in this file. This method and a few others (e.g., WriteLineMemorySpan, WriteCellMemory) use tabs for indentation, while the majority of the file uses spaces. Please ensure consistent formatting (spaces) throughout the file to improve readability and maintainability.

[gemini-code-assist]

Using cell.Replace("\"", "\"\"") creates a new string, which can lead to performance issues from memory allocations, especially with large cell values containing many quotes. For better performance, consider iterating through the string and writing segments to the TextWriter directly. The WriteCellMemory method already uses a similar, more performant pattern that could be adapted here.

[github-actions]

Stale pull request message

[stevehansen]

Fixed in b42fa35