Avoid redefining _GNU_SOURCE #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's harmless, but with 3dea342, we get: ``` x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/var/tmp/portage/sys-fs/libeatmydata-131/work/libeatmydata-131 -O2 -pipe -march=native -fdiagnostics-color=always -frecord-gcc-switches -Wreturn-type -ggdb3 -Werror=implicit-function-declaration -Werror=implicit-int -c -o libeatmydata/test/tst-cancel4.o /var/tmp/portage/sys-fs/libeatmydata-131/work/libeatmydata-131/libeatmydata/test/tst-cancel4.c /var/tmp/portage/sys-fs/libeatmydata-131/work/libeatmydata-131/libeatmydata/test/tst-cancel4.c:28: warning: "_GNU_SOURCE" redefined 28 | #define _GNU_SOURCE | In file included from /var/tmp/portage/sys-fs/libeatmydata-131/work/libeatmydata-131/libeatmydata/test/tst-cancel4.c:26: ./config.h:115: note: this is the location of the previous definition 115 | # define _GNU_SOURCE 1 | ``` This is because we already have `AC_USE_SYSTEM_EXTENSIONS` in configure.ac which sets GNU_SOURCE in config.h for us. We also explicitly add a config.h include to tst-invalidvd.c instead of relying on it via portability.h.
config.h is missing from this PR 🤔 |
Author
It's already there (generated by autoconf during the build). We're just using it more now (it's already included in the first file I touch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's harmless, but with 3dea342, we get:
This is because we already have
AC_USE_SYSTEM_EXTENSIONSin configure.ac which sets GNU_SOURCE in config.h for us.We also explicitly add a config.h include to tst-invalidvd.c instead of relying on it via portability.h.