Fix access to open() and open64() on 32bit also when built with a env defining _TIME_BITS #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… defining _TIME_BITS
distributions are now rebuilding 32bit archs and defining
_TIME_BITS=64
_FILE_OFFSET_BITS=64
to be able to use the redefined 64-bit time and file functions from
glibc.
Undefine _TIME_BITS here too, to prevent this compilation error:
> In file included from /usr/include/features.h:393,
> from /usr/include/arm-linux-gnueabihf/sys/types.h:25,
> from libeatmydata/libeatmydata.c:22:
> /usr/include/features-time64.h:26:5: error: #error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> 26 | # error "_TIME_BITS=64 is allowed only with _FILE_OFFSET_BITS=64"
> | ^~~~~
> make[2]: *** [Makefile:1046: libeatmydata/la-libeatmydata.lo] Error 1
Signed-off-by: Mattia Rizzolo <mattia@mapreri.org>
mapreri
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distributions are now rebuilding 32bit archs and defining
_TIME_BITS=64
_FILE_OFFSET_BITS=64
to be able to use the redefined 64-bit time and file functions from glibc.
Undefine _TIME_BITS here too, to prevent this compilation error: