Skip to content

(Closes #2360) Fixes for LFRic dependency analysis#2361

Merged
sergisiso merged 8 commits intomasterfrom
2360_lfric_da_fixes
Oct 18, 2023
Merged

(Closes #2360) Fixes for LFRic dependency analysis#2361
sergisiso merged 8 commits intomasterfrom
2360_lfric_da_fixes

Conversation

@arporter
Copy link
Member

A couple of small fixes identified when doing OpenACC for LFRic.

@arporter arporter self-assigned this Oct 11, 2023
@arporter arporter added the LFRic Issue relates to the LFRic domain label Oct 11, 2023
@arporter arporter marked this pull request as draft October 11, 2023 09:10
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d90d03d) 99.84% compared to head (4f7e2f8) 99.84%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2361      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files         348      348              
  Lines       47062    47073      +11     
==========================================
+ Hits        46990    47000      +10     
- Misses         72       73       +1     
Files Coverage Δ
src/psyclone/dynamo0p3.py 99.78% <100.00%> (-0.03%) ⬇️
...clone/psyir/transformations/parallel_loop_trans.py 100.00% <100.00%> (ø)
src/psyclone/transformations.py 99.40% <100.00%> (+<0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arporter arporter marked this pull request as ready for review October 11, 2023 10:37
@arporter
Copy link
Member Author

Small fixes that change the way DA is done for LFRic loops. These were needed to do ACC PARALLEL/LOOP for LFRic.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter it looks good, I just have some general questions about how these fits with other LFRic transformations/kernels. But feel free to disregard if it leads to complications.

@arporter
Copy link
Member Author

CI permitting, this is ready for another look.

@sergisiso sergisiso temporarily deployed to integration October 18, 2023 08:38 — with GitHub Actions Inactive
Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arporter Thanks for expanding the comments, the rest of the PR looks good. There are no TODOs remaining, linters don't show new issues, test and coverage pass. I am running integration but unless there is some error there, this is ready to merge.

@sergisiso sergisiso merged commit 7eafde3 into master Oct 18, 2023
@sergisiso sergisiso deleted the 2360_lfric_da_fixes branch October 18, 2023 09:39
arporter added a commit that referenced this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LFRic Issue relates to the LFRic domain ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants