(Closes #2360) Fixes for LFRic dependency analysis#2361
Merged
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2361 +/- ##
==========================================
- Coverage 99.84% 99.84% -0.01%
==========================================
Files 348 348
Lines 47062 47073 +11
==========================================
+ Hits 46990 47000 +10
- Misses 72 73 +1
☔ View full report in Codecov by Sentry. |
Member
Author
|
Small fixes that change the way DA is done for LFRic loops. These were needed to do ACC PARALLEL/LOOP for LFRic. |
Member
Author
|
CI permitting, this is ready for another look. |
sergisiso
approved these changes
Oct 18, 2023
Collaborator
sergisiso
left a comment
There was a problem hiding this comment.
@arporter Thanks for expanding the comments, the rest of the PR looks good. There are no TODOs remaining, linters don't show new issues, test and coverage pass. I am running integration but unless there is some error there, this is ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of small fixes identified when doing OpenACC for LFRic.