(towards #3083) Scaffolding for Treesitter frontend#3351
Open
(towards #3083) Scaffolding for Treesitter frontend#3351
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3351 +/- ##
========================================
Coverage 99.95% 99.95%
========================================
Files 387 388 +1
Lines 54315 54432 +117
========================================
+ Hits 54293 54410 +117
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a barebones treesitter frontend that allows to do:
psyclone --frontend treesitter test.f90to essentially generate a treesitter codeblock encompassing the whole file. This needed a few changes because the CodeBlock and Reader only had one concrete class each and fparser was leaking in many places.This PR:
The performance of treesitter won't be ideal until all leaks of fparser are container (e.g. it is only lazy loaded from inside its reader and codeblock), because a large part of the fparser performance hit is at import time.
Hopefully follow on PRs can be more contained inside the reader class.