(Closes #1734 #2975 #2949) Add stricter checking for symbols#3358
Merged
(Closes #1734 #2975 #2949) Add stricter checking for symbols#3358
Conversation
Member
Author
|
Ready for another look now @sergisiso. I've fired off the ITs again... |
arporter
changed the title
Member
Author
|
Ready for another look now @sergisiso |
sergisiso
approved these changes
Mar 23, 2026
Collaborator
sergisiso
left a comment
sergisiso
left a comment
There was a problem hiding this comment.
@arporter All comments have been adressed, the integration test pass and the coverage is complete. As mentioned before, this is a big improvement for lfric symbol consistency, and now the places where I still have doubts have better comments and TODOs associated, so this is approved for merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've broken this out of the work on #1823 - that work revealed issues with our Symbol handling so I thought I might as well do the job properly.
We now no longer add a wildcard import of
constants_modin LFRic generated code. This revealed a few bugs/misssing symbols that I've now fixed.