Skip to content

3252 lfric value range example#3378

Merged
sergisiso merged 10 commits intomasterfrom
3252_lfric_value_range_example
Mar 23, 2026
Merged

3252 lfric value range example#3378
sergisiso merged 10 commits intomasterfrom
3252_lfric_value_range_example

Conversation

@hiker
Copy link
Collaborator

@hiker hiker commented Mar 17, 2026

I forgot about this example, I think I wanted to add it to the previous value range PR. Well, here it is as a stand-alone PR now. Adding a ValueRangeCheck example for LFRic (and minor fixes to the extraction documentation).

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (de3eaf3) to head (0c7f9ad).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3378   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         387      387           
  Lines       54269    54269           
=======================================
  Hits        54247    54247           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hiker
Copy link
Collaborator Author

hiker commented Mar 18, 2026

IT passed, ready for review.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the example @hiker, there is only some minor clean up to do and a question about some part of the README that I couldn't reproduce.

@hiker
Copy link
Collaborator Author

hiker commented Mar 20, 2026

I will trigger IT later.

@hiker
Copy link
Collaborator Author

hiker commented Mar 23, 2026

IT passed as well, ready for next review.

Copy link
Collaborator

@sergisiso sergisiso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiker All comments have been adressed and the integration test pass. This is ready to merge.

@sergisiso sergisiso merged commit 63d8c53 into master Mar 23, 2026
15 checks passed
@sergisiso sergisiso deleted the 3252_lfric_value_range_example branch March 23, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants