-
Notifications
You must be signed in to change notification settings - Fork 113
Open
Description
Thanks to your great work and research, I could adapt your method to create a remote route in my brand-new Qt target-browser.
While trying it out, I think, I found a mismatch in the offsets and meanings of the reply struct.
Line 369 in 1dd518b
| if rcvd_is_password_correct == b"\x04\x00\x00": |
In my observed cases, I received at offset 26:
- 04000000 on success
- 04000407 on password failure
So, in my case, the first "04" does not help distinguish, the offset of the "0407" on failure is actually plus one in my case and I think, the last two bytes are little-endian uint16 for the ADSERR_DEVICE_* errors. At least 0x0704 means ADSERR_DEVICE_INVALIDACCESS which kind of makes sense for wrong passwords.
See my parsing struct.
Metadata
Metadata
Assignees
Labels
No labels