Skip to content

Conversation

@RobertoRoos
Copy link
Contributor

@RobertoRoos RobertoRoos commented Sep 13, 2024

Trying to improve string handling to solve some of the open issues.

Frankly I'm a bit lost what the issues are exactly, I'm trying to go through them slowly. EDIT: Okay, I think this is about it for now. I think this resolves all string issues?

Resolves:

Should resolve (but I haven't reproduced the issue before):

Obsoletes other PRs:

@coveralls
Copy link

coveralls commented Sep 13, 2024

Pull Request Test Coverage Report for Build 10849949250

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 95.0%

Totals Coverage Status
Change from base Build 10633721828: 0.05%
Covered Lines: 1729
Relevant Lines: 1820

💛 - Coveralls

@RobertoRoos RobertoRoos marked this pull request as ready for review September 13, 2024 13:09
@RobertoRoos RobertoRoos changed the title String array fixes String and string array fixes Sep 13, 2024
@RobertoRoos
Copy link
Contributor Author

Okay, I think I'm done. @chrisbeardy whadda think? @stlehmann maybe?

@rassMarel
Copy link

Hello there
Are there any plans for merging this fix and releasing it?
I have been having the same issues when I was trying to read arrays of strings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants