-
Notifications
You must be signed in to change notification settings - Fork 113
Updated setuptools with adslib in wheel distribution and pyproject.toml
#426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
76b71fe to
131d655
Compare
Pull Request Test Coverage Report for Build 11027487472Details
💛 - Coveralls |
131d655 to
9caa407
Compare
|
EDIT: Okay, solved. By moving the compiled See a test of the distribution wheels in: https://github.com/RobertoRoos/pyads/actions/runs/11010369726 |
42a06cd to
d944b8c
Compare
d944b8c to
a5e0963
Compare
|
Okay, I think I'm happy with this now. |
|
Thanks @RobertoRoos , the idea of moving towards pyproject toml is very good and something that felt daunting to do so I'm glad someone managed it!. I will review these changes when I get back from vacation |
|
@RobertoRoos Thanks for the great work here. I just did a rebase and see if all works well. Would you mind setting “Allow Edits from Maintainers” for this PR? |
|
@stlehmann you're very welcome! I think maintainer access is checked. (I'm on mobile for the foreseeable future, not used to GH like that :p ) |
|
Moved this to #469 because of rebase. |
I think this is pretty close to what I had in mind. This would resolved #425 .
I based this on top of a developing brach I had to switch over to
pyproject.toml, so the diff is quite big.Check the pipelines running on my fork to see what the distributions would look like.
And this PR will likely conflict with #412 and maybe with #399 .