Skip to content

Conversation

@dewabe
Copy link
Contributor

@dewabe dewabe commented Dec 18, 2025

Just a small thing, but enhancement anyway

Based on #457

@chrisbeardy
Copy link
Collaborator

this is great! Please tell me you didn't do this manually, must have taken ages! thanks! To maintain compatibility with python 3.8 which we currently still support, can you remove the typing please. Given they are constants I see no harm at the moment, or use 3.8 compatible typing. Thanks.

@coveralls
Copy link

coveralls commented Dec 18, 2025

Pull Request Test Coverage Report for Build 20347441845

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.887%

Totals Coverage Status
Change from base Build 20267830446: 0.05%
Covered Lines: 1797
Relevant Lines: 1914

💛 - Coveralls

@dewabe
Copy link
Contributor Author

dewabe commented Dec 18, 2025

To be honest, no. I did not do this manually. I started it manually, but no.. In my opinion, such a task is good to give to AI to pre-progress, and the validity can be checked afterwards. Obviously, not all the lines are double checked by me but many are.

Anyway:
Typing is removed now!

@chrisbeardy
Copy link
Collaborator

I completetly agree

@chrisbeardy chrisbeardy merged commit ad0c13e into stlehmann:master Dec 19, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants