Skip to content

add istio multicluster servicemesh application on acm.#19

Merged
openshift-merge-robot merged 1 commit intostolostron:mainfrom
morvencao:br_add_istio_application
Sep 30, 2021
Merged

add istio multicluster servicemesh application on acm.#19
openshift-merge-robot merged 1 commit intostolostron:mainfrom
morvencao:br_add_istio_application

Conversation

@morvencao
Copy link
Copy Markdown
Contributor

Signed-off-by: morvencao lcao@redhat.com

Signed-off-by: morvencao <lcao@redhat.com>
@morvencao
Copy link
Copy Markdown
Contributor Author

/cc @jnpacker

@openshift-ci openshift-ci Bot requested a review from jnpacker September 29, 2021 13:45
@morvencao
Copy link
Copy Markdown
Contributor Author

/assign @fxiang1

Copy link
Copy Markdown
Contributor

@fxiang1 fxiang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci Bot added the lgtm label Sep 30, 2021
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Sep 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fxiang1, morvencao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8d8dc1c into stolostron:main Sep 30, 2021
@morvencao morvencao deleted the br_add_istio_application branch September 30, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants