Feat/refactor teams and add registry #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudo-owen
pushed a commit
that referenced
this pull request
Jan 16, 2026
This commit fixes several critical issues in the doubles implementation: Issue #1: Switch effects now pass explicit monIndex - _handleSwitchCore passes currentActiveMonIndex to switch-out effects - _completeSwitchIn passes monToSwitchIndex to switch-in effects Issue #2: Move validation now receives slotIndex - validateSpecificMoveSelection accepts slotIndex parameter - Uses _getActiveMonIndexFromContext to get correct mon for validation Issue #3: AfterDamage effects pass explicit monIndex - dealDamage now passes monIndex to effect execution Issue #4: OnUpdateMonState effects pass explicit monIndex - updateMonState now passes monIndex to effect execution Also adds: - Overloaded _runEffects that accepts explicit monIndex - EffectApplyingAttack mock for testing - MonIndexTrackingEffect mock for testing - Tests: test_afterDamageEffectsRunOnCorrectMon, test_moveValidationUsesCorrectSlotMon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.