Mark _get_linux_version() as static

[mbiebl]

It is an internal implementation detail and the symbol should not be exported via libblockdev-utils.

[gemini-code-assist]

Summary of Changes

Hello @mbiebl, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the internal structure of libblockdev-utils by restricting the visibility of the _get_linux_version() function. By marking it as static, the change prevents its unintended exposure and usage outside its defining compilation unit, thereby reinforcing the library's internal design principles and reducing potential for external dependency on an internal utility.

Highlights

• Function Visibility: The _get_linux_version() function in src/utils/module.c has been marked as static.
• Encapsulation: This change ensures that _get_linux_version() remains an internal implementation detail and is not exported via libblockdev-utils, improving encapsulation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly marks the _get_linux_version function as static to limit its scope to the compilation unit. This is a good practice as the function is an internal implementation detail and should not have its symbol exported by the library. The change is correct and improves code quality by enhancing encapsulation. The change is approved.

[vojtechtrefny]

Thank you, I am not sure how I missed this...

[tbzatek]

Sounds good!