This repository is currently being migrated. It's locked while the migration is in progress.
Fix StorageOS volume hash calculation and status update #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmxs
force-pushed
the
fix-volume-status-update
branch
from
3f5e475 to
38b8112
Compare
Mojachieee
reviewed
Apr 6, 2022
| } | ||
|
|
||
| hash := []byte{} | ||
| for _, s := range [][]byte{[]byte(stosVol.Id), []byte(stosVol.CreatedAt.String()), raw} { |
Collaborator
There was a problem hiding this comment.
What's the benefit of hashing the id, the createdAt and the entire raw json string?
Doesn't the entire json string contain the id and createdAt anyway?
Contributor
Author
There was a problem hiding this comment.
The reason is we convert undefined number of any characters to ~19 digits. Because the output is slimmer than the input, we have some chance for collision. So this should power the output space and drastically decreases chance of collision.
Mojachieee
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases after we patched volume object via
CreateOrPatchit loads status from Kubernetes back, so next status update does nothung. To avoid this situation the new way applies status changes afterCreateOrPatchso we always persist the latest state.Meanwhile i was not happy to keep entire json objects in memory as volume hash, so i implemented a proper hash function.