This repository is currently being migrated. It's locked while the migration is in progress.
Tune leader election #136
Merged
Tune leader election #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mojachieee
approved these changes
Jun 6, 2022
main.go
Outdated
| LeaderElection: enableLeaderElection, | ||
| LeaderElectionID: "storageos-api-manager-leader", | ||
| LeaderElectionNamespace: namespace, | ||
| LeaderElectionResourceLock: "leases", |
Collaborator
There was a problem hiding this comment.
Same comment as before:
nit: I believe you can use the constant k8s.io/client-go/tools/leaderelection/resourcelock. LeasesResourceLock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase timeout of leader election.
Removal of legacy multi-lock to lease lock only.
Command-line flag to set renewal seconds.