This repository is currently being migrated. It's locked while the migration is in progress.
stop api-manager setting scheduler name when scheduler is disabled #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolancon
reviewed
Oct 6, 2022
Collaborator
nolancon
left a comment
nolancon
left a comment
There was a problem hiding this comment.
will this append another --scheduler-name= arg every time the controller reconciles?
Collaborator
Author
Nope, it's only applying the transforms to the content in |
nolancon
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a webhook that sets the
schedulerNametostorageos-schedulerfor any pods that mount storageos volumes. If we disable the scheduler we also want to stop this webhook.This PR makes the webhook not set the
schedulerName, which means it will default todefaultScheduler. It's not entirely foolproof, as a customer may want to set aschedulerName, at which point I think we'd overwrite it