models - anthropic #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Patrick Gray <pgrayy@amazon.com> Co-authored-by: Jason Kim <jkim@anthropic.com>
pgrayy
approved these changes
May 16, 2025
satsumas
added a commit
to Stability-AI/strands-sdk-python
that referenced
this pull request
Jun 23, 2025
…y-integration Stability integration
mkmeral
pushed a commit
to mkmeral/sdk-python
that referenced
this pull request
Nov 10, 2025
feat: (Agent): Finalize Bidirectional Agent class
mkmeral
pushed a commit
to mkmeral/sdk-python
that referenced
this pull request
Jan 9, 2026
- Fix invoke_async to delegate to stream_async (prevents returning first incomplete event) - Add async context manager support (__aenter__/__aexit__) and explicit aclose() method - Improve __del__ cleanup to handle event loop edge cases - Change logger.info to logger.debug for consistency with project standards - Simplify factory creation with _create_default_factory() helper method - Add comprehensive documentation to A2AStreamEvent - Improve test fixture pattern with pytest fixture for subprocess management - Add comprehensive e2e tests for invoke_async, stream_async, and context manager Addresses PR strands-agents#1174 review comments: - Comment strands-agents#2: Critical bug - invoke_async now waits for complete events - Comment strands-agents#5: Code duplication - invoke_async delegates to stream_async - Comment strands-agents#6: Async cleanup - proper async context manager pattern - Comment strands-agents#3: Logging level - changed to debug - Comment strands-agents#4: Factory simplification - extracted helper method - Comment strands-agents#12: Documentation - documented A2AStreamEvent behavior - Comment strands-agents#9: Test fixture - using pytest fixture pattern - Comment strands-agents#10: Test coverage - added comprehensive e2e tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Anthropic Claude API support to the SDK, enabling integration with Claude models for agent functionality. This implementation includes proper message formatting, tool use
handling, and media support.
Documentation PR
PR in the agent-docs repo will be submitted separately.
Type of Change
Testing
[How have you tested the change?]
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.