-
Notifications
You must be signed in to change notification settings - Fork 628
fix: provide unique toolUseId for gemini models #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: provide unique toolUseId for gemini models #1201
Conversation
|
Last note, can you make sure to run |
…ected tooluseid in relevant test
yes, I finally got it working :) thank you |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@AirswitchAsa can you merge from main? There are some failing checks, and merge from main should fix those. I'll approve the change as is. It won't get merged without passing approval workflows, and merge from main won't impact my approval |
Sorry that I just saw your comment - I have just merged it with latest main |
|
Hi @AirswitchAsa @mkmeral @pgrayy Bumping this thread as this bug is currently a blocker for our workflow. It looks like the review feedback was addressed back in December and that the PR (after resolving the conflicts) should be good to go. Is there anything blocking this? We’d really appreciate seeing this merged soon. Thanks for your work on this! |
I am not sure.. @mkmeral I just merged main again. Let me know if you need anything else on this PR. |
…nto fix-gemini-tooluseid
|
@AirswitchAsa apologies for the delay. Just need one more reviewer. |
Description
The
toolUseIdfield is supposed to provide an unique identifier of the tool use to the user, but it was instead filled with the tool name if user is using a Gemini model. Reason behind is that Gemini requires that name be set in the equivalentFunctionResponsetype. Consequently, the current code assigns tool name totoolUseIdin the tool use block.As a solution, this PR proposes the following changes:
_tool_use_id_to_nameupon initializationFunctionResponseRelated Issues
#1200
Documentation PR
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareprepare-results.txt
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.