fix(a2a): use a2a artifact update event #1401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycewcole
requested a deployment
to
manual-approval
GitHub Actions
Waiting
brycewcole
force-pushed
the
a2a-artifact-update
branch
from
4fca63b to
4b5ba77
Compare
brycewcole
requested a deployment
to
manual-approval
GitHub Actions
Waiting
brycewcole
force-pushed
the
a2a-artifact-update
branch
from
4b5ba77 to
39aab40
Compare
brycewcole
requested a deployment
to
manual-approval
GitHub Actions
Waiting
brycewcole
changed the title
3 tasks
Unshure
reviewed
Jan 14, 2026
Member
Unshure
left a comment
Unshure
left a comment
There was a problem hiding this comment.
Lets make sure to put this new behavior behind the enable_a2a_compliant_streaming flag so that existing integrations are not impacted, but notified of this change.
brycewcole
requested a deployment
to
manual-approval
GitHub Actions
Waiting
brycewcole
force-pushed
the
a2a-artifact-update
branch
from
7574c91 to
350c9da
Compare
brycewcole
had a problem deploying
to
manual-approval
GitHub Actions
Failure
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Unshure
reviewed
Jan 14, 2026
Member
Unshure
left a comment
Unshure
left a comment
There was a problem hiding this comment.
Code looks good, but a few of our tests failed. Left some comments throughout about ways to address it.
fix: update tests fix: simplify code by storing in class fix: remove uneeded code change fix: hide a2a artifact streaming under feature flag fix: use walrus operator fix: use star to signify end of unnamed fix: add check for walrus legacy fix: clarify enable_a2a_compliant_streaming parameter in StrandsA2AExecutor initialization fix: update tests refactor: streamline artifact addition logic in StrandsA2AExecutor
brycewcole
force-pushed
the
a2a-artifact-update
branch
from
350c9da to
1766f35
Compare
brycewcole
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
Unshure
approved these changes
Jan 15, 2026
Member
Unshure
left a comment
Unshure
left a comment
There was a problem hiding this comment.
Codecov is 2% off, which I think is fine. And the api diff check sees the additional enable_a2a_compliant_streaming parameter as potentially breaking, but its been implemented such that it wont break existing users
zastrowm
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the a2a executor to use the a2a libraries artifact append function. Intermediate chunks are best represented by artifact updates with append set to true, not task status updates. Please see this discussion on the a2a repo for more justification.
This feature is now hidden behind the
enable_a2a_compliant_streamingflag inA2AServer.enable_a2a_compliant_streaming False
enable_a2a_compliant_streaming True
Related Issues
#1377
Documentation PR
N/A
Type of Change
Bug fix
Testing
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.