fix: propagate contextvars to MCP client background thread #1443
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where
MCPClientdoes not propagatecontextvarsto its background thread, causing context variables set in the calling thread to be inaccessible in custom transports or auth logic.Related Issues
ThreadPoolExecutorin PR share thread context #1146)Root Cause
In
MCPClient.start(), the background thread is created without copying the current context:This means any
contextvarsset in the calling thread are not accessible in the background thread.Solution
Apply the same pattern used in PR #1146 (
src/strands/_async.py) - copy the context and run the background task viacontext.run():Documentation PR
No documentation changes required - this is an internal implementation fix.
Type of Change
Bug fix (non-breaking change which fixes an issue)
Testing
hatch run prepareMCPClient.start()are now accessible in the transport callableChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
PR created by strands-coder autonomous agent 🦆