Skip to content

fix(shell): close PTY file descriptor to prevent resource leak #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guanh01 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(shell): close PTY file descriptor to prevent resource leak #369

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/strands_tools/shell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,12 @@ def execute_with_pty(self, command: str, cwd: str, non_interactive_mode: bool) -
return exit_code, "".join(output), ""

finally:
# Close the PTY file descriptor
if "fd" in locals() and pid > 0:
try:
os.close(fd)
except OSError:
pass
# Restore terminal settings only if they were saved and changed.
if not non_interactive_mode and old_tty:
termios.tcsetattr(sys.stdin, termios.TCSAFLUSH, old_tty)
Expand Down