Rpc contracts #10
Merged
Rpc contracts #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalaninja
force-pushed
the
feature/rpc-contracts
branch
from
791d9c8 to
04bc9d1
Compare
vnabiev
reviewed
Feb 11, 2022
| private final boolean value; | ||
|
|
||
| @Override | ||
| public boolean isNull() { |
Collaborator
There was a problem hiding this comment.
I would propose to make each method returns false by default and throws IllegalStateException appropriately at RpcObject and then just to override methods that relate to the
particular implementation. It'll reduce repetetive code.
kalaninja
force-pushed
the
feature/rpc-contracts
branch
from
04bc9d1 to
edbb6af
Compare
vnabiev
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.