Refractor update_mempool module in JDS mempool module for simplified async flow#833
Conversation
|
@GitGab19 I have re-reviewed and made some changes here, please I am requesting a review here and also to point out that the MG test is still failing |
|
I will do it by the next week! |
lorbax
left a comment
There was a problem hiding this comment.
This is a good PR
I would be good to have the minor changes that I left as comments
|
@lorbax i have been able to manage the unhappy paths in the the update_mempool function, please I request your feedback on this before I pick up the next issue. Thanks |
|
@NonsoAmadi10 can you rebase? |
|
Alright I am on it |
|
@lorbax once you do the final review here, are you able to approve? |
e1ef7b0 to
e3d8197
Compare
|
This PR needs to be rebased on dev |
10dce88 to
877f265
Compare
|
@NonsoAmadi10 you must also remove the TokioJoin variant of JdsMempoolError |
|
The right pattern to follow when we implement a variant that is only a container for an error that come from a library is to implement https://github.com/stratum-mining/stratum/blob/main/roles/jd-server/src/lib/error.rs#L55 |
lorbax
left a comment
There was a problem hiding this comment.
Run local TP, pool, jds, jdc, tproxy and cpuminer without issues.
The code looks good to me.
0c45c76 to
4f8bdf1
Compare
What does this PR do?
Closes #784