Skip to content

Fix incorrect y-coordinate when drawing text-box#9

Closed
Saba-Sabato wants to merge 2 commits intostraussmaximilian:mainfrom
Saba-Sabato:main
Closed

Fix incorrect y-coordinate when drawing text-box#9
Saba-Sabato wants to merge 2 commits intostraussmaximilian:mainfrom
Saba-Sabato:main

Conversation

@Saba-Sabato
Copy link
Copy Markdown
Contributor

Hi! Really appreciate this package, thanks.
Following the fix in #6 , we need to update the y-coordinate for drawing the textbox too.
I have also added some tests and docs, if this is too much feel free to drop the other commit or edit as you see fit. Thanks!

@straussmaximilian
Copy link
Copy Markdown
Owner

Hi,
this is great, thanks!
I made a couple of adjustments:

  • Typing caused issues with Python 3.8, so I made it backward compatible
  • I changed the test a bit to know which word fails
  • For some reason, there were slight differences in the test images, so tests failed
  • I made the tests more specific by adding the language preference
  • I made a confidence parameter to filter out based on confidence
  • This still didn't fix the issue, so I now included an MSE score to roughly compare the images.

For some reason it didn't push to this branch, so the PR is now here #10

@Saba-Sabato
Copy link
Copy Markdown
Contributor Author

Thanks for taking the time to go over it and make the required corrections!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants