Fix incorrect y-coordinate when drawing text-box#9
Closed
Saba-Sabato wants to merge 2 commits intostraussmaximilian:mainfrom
Closed
Fix incorrect y-coordinate when drawing text-box#9Saba-Sabato wants to merge 2 commits intostraussmaximilian:mainfrom
Saba-Sabato wants to merge 2 commits intostraussmaximilian:mainfrom
Conversation
Owner
|
Hi,
For some reason it didn't push to this branch, so the PR is now here #10 |
Merged
Contributor
Author
|
Thanks for taking the time to go over it and make the required corrections! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! Really appreciate this package, thanks.
Following the fix in #6 , we need to update the y-coordinate for drawing the textbox too.
I have also added some tests and docs, if this is too much feel free to drop the other commit or edit as you see fit. Thanks!