[fix] Release EntryImpl while reading exchange topic
#1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaoran10
commented
Jun 5, 2024
| this.readMoreEntries(); | ||
| } | ||
| }, routeExecutor); | ||
| entry.getRight().release(); |
Collaborator
Author
There was a problem hiding this comment.
This is the key point, we should release the entry directly.
gaoran10
commented
Jun 5, 2024
| propsList.add(Pair.of(entry.getPosition(), props)); | ||
| topic.getDispatchRateLimiter().ifPresent( | ||
| limiter -> limiter.consumeDispatchQuota(1, entry.getLength())); | ||
| entry.release(); |
Collaborator
Author
There was a problem hiding this comment.
Release the entry after collecting route information.
codelipenghui
previously approved these changes
Jun 6, 2024
tests/src/test/java/io/streamnative/pulsar/handlers/amqp/rabbitmq/RabbitMQMessagingTest.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/io/streamnative/pulsar/handlers/amqp/AmqpProtocolHandlerTestBase.java
Show resolved
Hide resolved
codelipenghui
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The PR introduced the InflightReadsLimiter, the exchange replicator will read data and route index data to the queue topic, but it doesn't release the EntryImpl object, this will cause the broker in-flight read cache limiter to be exhausted.
Modifications
Release
EntryImplobject while reading the exchange topic.Use topic dispatch limiter to control read batch size.
Verifying this change
Add test to verify the in-flight read cache can't be exhausted.
Does this pull request potentially affect one of the following parts:
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)