Apply new getAppliedAdvertisedAddress signature #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
a team,
codelipenghui and
gaoran10
as code owners
codelipenghui
approved these changes
Jul 2, 2021
gaoran10
approved these changes
Jul 2, 2021
gaoran10
pushed a commit
that referenced
this pull request
Jul 2, 2021
* Apply new getAppliedAdvertisedAddress interface * Set ignoreAdvertisedListener to true
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
apache/pulsar#10961 changed the method signature of
ServiceConfigurationUtils#getAppliedAdvertisedAddress, which causes AoP build failure.Modifications
Upgrade the Pulsar dependency to 2.8.0.4 that contains apache/pulsar#10961, then add the second parameter to
getAppliedAdvertisedAddress.It should be noted that since Pulsar 2.8.0.4 introduced the API incompatibility with 2.8.0, after this change, AoP >= 2.8.0.4 cannot be compatible with Pulsar < 2.8.0.4 including the stable version 2.8.0.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.