Skip to content

[SQL Connector] Fix catalog default-database creation #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cbornet wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[SQL Connector] Fix catalog default-database creation #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c82d241
Fix catalog default-database creation
cbornet Mar 23, 2023
a708cba
Fix format
cbornet Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ...r-pulsar/src/main/java/org/apache/flink/connector/pulsar/table/catalog/PulsarCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@
import java.util.List;
import java.util.Optional;

import static org.apache.flink.connector.pulsar.table.catalog.PulsarCatalogFactoryOptions.DEFAULT_DATABASE;

/**
* Catalog implementation to use Pulsar to store metadatas for Flink tables/databases.
*
Expand Down Expand Up @@ -123,7 +121,7 @@ public void open() throws CatalogException {
CatalogDatabaseImpl defaultDatabase =
new CatalogDatabaseImpl(new HashMap<>(), "The default database for PulsarCatalog");
try {
createDatabase(catalogConfiguration.get(DEFAULT_DATABASE), defaultDatabase, true);
createDatabase(getDefaultDatabase(), defaultDatabase, true);
} catch (DatabaseAlreadyExistException e) {
throw new CatalogException(
"Error: should ignore default database if not exist instead of throwing exception");
Expand Down