This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Make ProducerIdManager an interface #1061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
added
type/feature
BewareMyPower
approved these changes
Feb 10, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 10, 2022
This is a preliminary refactor that makes ProducerIdManager an interface. The plan is to contribute a new implementation of ProducerIdManager that does not use the MetadataStore service (ZooKeeper) but it stores the ids on a Pulsar topic. Using Pulsar as backing store for generating the ids is better when you are using this feature in a MultiTenant environment and you want to fully isolate the data of each tenants.
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 10, 2022
This is a preliminary refactor that makes ProducerIdManager an interface. The plan is to contribute a new implementation of ProducerIdManager that does not use the MetadataStore service (ZooKeeper) but it stores the ids on a Pulsar topic. Using Pulsar as backing store for generating the ids is better when you are using this feature in a MultiTenant environment and you want to fully isolate the data of each tenants. (cherry picked from commit b07222d)
Collaborator
|
@Demogorgon314 Could you help cherry-pick this PR to branch-2.8.2? I met some conflicts in <<<<<<< HEAD:tests/src/test/java/io/streamnative/pulsar/handlers/kop/coordinator/transaction/ProducerIdManagerTest.java
Stat stat = mockZooKeeper.exists(ProducerIdManager.KOP_PID_BLOCK_ZNODE, null);
if (stat != null) {
mockZooKeeper.delete(ProducerIdManager.KOP_PID_BLOCK_ZNODE, -1);
}
=======
pulsar.getLocalMetadataStore()
.deleteRecursive(ProducerIdManagerImpl.KOP_PID_BLOCK_ZNODE).get(10, TimeUnit.SECONDS);
>>>>>>> b07222d (Make ProducerIdManager an interface (#1061)):tests/src/test/java/io/streamnative/pulsar/handlers/kop/coordinator/transaction/ProducerIdManagerImplTest.java |
Demogorgon314
pushed a commit
that referenced
this pull request
Feb 10, 2022
This is a preliminary refactor that makes ProducerIdManager an interface. The plan is to contribute a new implementation of ProducerIdManager that does not use the MetadataStore service (ZooKeeper) but it stores the ids on a Pulsar topic. Using Pulsar as backing store for generating the ids is better when you are using this feature in a MultiTenant environment and you want to fully isolate the data of each tenants. (cherry picked from commit b07222d)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preliminary refactor that makes ProducerIdManager an interface.
The plan is to contribute a new implementation of ProducerIdManager that does not use the MetadataStore service (ZooKeeper) but it stores the ids on a Pulsar topic.
Using Pulsar as backing store for generating the ids is better when you are using this feature in a MultiTenant environment and you want to fully isolate the data of each tenants.