This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Remove isMarkerMessage method in KoP MessagePublishContext #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
requested review from
BewareMyPower and
jiazhai
as code owners
BewareMyPower
approved these changes
Feb 10, 2022
Demogorgon314
added a commit
that referenced
this pull request
Feb 11, 2022
### Motivation The `isMarkerMessage` method is used for `ReplicatedSubscriptions`, we should use `isMarkerMessage` in KoP. ### Modifications Do not override `isMarkerMessage ` method in KoP MessagePublishContext. (cherry picked from commit 19d3a3a)
Demogorgon314
added a commit
that referenced
this pull request
Feb 11, 2022
### Motivation The `isMarkerMessage` method is used for `ReplicatedSubscriptions`, we should use `isMarkerMessage` in KoP. ### Modifications Do not override `isMarkerMessage ` method in KoP MessagePublishContext. (cherry picked from commit 19d3a3a)
Demogorgon314
added a commit
that referenced
this pull request
Feb 11, 2022
### Motivation The `isMarkerMessage` method is used for `ReplicatedSubscriptions`, we should use `isMarkerMessage` in KoP. ### Modifications Do not override `isMarkerMessage ` method in KoP MessagePublishContext. (cherry picked from commit 19d3a3a)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
isMarkerMessagemethod is used forReplicatedSubscriptions, we should useisMarkerMessagein KoP.Modifications
Do not override
isMarkerMessagemethod in KoP MessagePublishContext.