Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Fix Netty buffer / direct memory leak in MessageFetchContext #1069

Merged
BewareMyPower merged 1 commit into from
Feb 11, 2022
Merged

Fix Netty buffer / direct memory leak in MessageFetchContext #1069

BewareMyPower merged 1 commit into from
Feb 11, 2022

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Feb 11, 2022

@lhotari
Fix Netty buffer / direct memory leak in MessageFetchContext
a30967e 
- streamnative#1049 changed behavior, therefore this change is needed
@CLAassistant
Copy link

CLAassistant commented Feb 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

eolivelli
eolivelli approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I am testing this change

thank you @lhotari

@eolivelli
Copy link
Contributor

eolivelli commented Feb 11, 2022

I confirm that this fix resolves the memory I was investigating

@BewareMyPower BewareMyPower mentioned this pull request Feb 11, 2022
Merged
@BewareMyPower BewareMyPower merged commit bf2331a into streamnative:master Feb 11, 2022
BewareMyPower pushed a commit that referenced this pull request Feb 11, 2022
@lhotari @BewareMyPower
Fix Netty buffer / direct memory leak in MessageFetchContext (#1069)
50d6f7c 
- #1049 changed behavior, therefore this change is needed

(cherry picked from commit bf2331a)
BewareMyPower pushed a commit that referenced this pull request Feb 11, 2022
@lhotari @BewareMyPower
Fix Netty buffer / direct memory leak in MessageFetchContext (#1069)
558959b 
- #1049 changed behavior, therefore this change is needed

(cherry picked from commit bf2331a)
BewareMyPower pushed a commit that referenced this pull request Feb 11, 2022
@lhotari @BewareMyPower
Fix Netty buffer / direct memory leak in MessageFetchContext (#1069)
25590ef 
- #1049 changed behavior, therefore this change is needed

(cherry picked from commit bf2331a)
@BewareMyPower BewareMyPower mentioned this pull request Feb 17, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jiazhai jiazhai Awaiting requested review from jiazhai

3 more reviewers

@eolivelli eolivelli eolivelli approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lhotari lhotari

Labels

cherry-picked/branch-2.8.2 cherry-picked/branch-2.9.2 cherry-picked/branch-2.10.0 release/2.8.2.x release/2.9.2 release/2.10.0 type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lhotari @CLAassistant @eolivelli @BewareMyPower @Demogorgon314