This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Transactions: don't create a thread per-tenant #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use a shared threadpool - lazily start the drainQueuedTransactionMarkers activity only when needed - set period to 100ms (instead of 1ms)
Contributor
Author
|
CI failed, checking |
Contributor
Author
|
Ci passed |
...treamnative/pulsar/handlers/kop/coordinator/transaction/TransactionMarkerChannelManager.java
Show resolved
Hide resolved
BewareMyPower
added
release/2.10.0
release/2.8.2.x
release/2.9.2
type/enhancement
BewareMyPower
approved these changes
Feb 24, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 25, 2022
**Modifications** - use a shared threadpool - lazily start the drainQueuedTransactionMarkers activity only when needed - set period to 100ms (instead of 1ms) **Result** If a tenant never uses transactions, then you never start the background activity, also we are able to scale the number for active tenants. A future improvement may be to shutdown the activity when a tenant is idle for a while (cherry picked from commit 12cf707)
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 25, 2022
**Modifications** - use a shared threadpool - lazily start the drainQueuedTransactionMarkers activity only when needed - set period to 100ms (instead of 1ms) **Result** If a tenant never uses transactions, then you never start the background activity, also we are able to scale the number for active tenants. A future improvement may be to shutdown the activity when a tenant is idle for a while (cherry picked from commit 12cf707)
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 25, 2022
**Modifications** - use a shared threadpool - lazily start the drainQueuedTransactionMarkers activity only when needed - set period to 100ms (instead of 1ms) **Result** If a tenant never uses transactions, then you never start the background activity, also we are able to scale the number for active tenants. A future improvement may be to shutdown the activity when a tenant is idle for a while (cherry picked from commit 12cf707)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Result
If a tenant never uses transactions, then you never start the background activity, also we are able to scale the number for active tenants.
A future improvement may be to shutdown the activity when a tenant is idle for a while