This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[Transaction] Able to disable transaction coordinator #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
requested review from
BewareMyPower and
jiazhai
as code owners
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Feb 17, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 18, 2022
Fixes #1090 ### Motivation Currently, even if we config kafkaTransactionCoordinatorEnabled=false, the Kafka transaction coordinator is still started. It happened when the broker has a consumer fetch message. ### Modifications When `kafkaTransactionCoordinatorEnabled = false`, ensure the transaction coordinator don't start.
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 18, 2022
Fixes #1090 ### Motivation Currently, even if we config kafkaTransactionCoordinatorEnabled=false, the Kafka transaction coordinator is still started. It happened when the broker has a consumer fetch message. ### Modifications When `kafkaTransactionCoordinatorEnabled = false`, ensure the transaction coordinator don't start. (cherry picked from commit 1415c6e)
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 18, 2022
Fixes #1090 ### Motivation Currently, even if we config kafkaTransactionCoordinatorEnabled=false, the Kafka transaction coordinator is still started. It happened when the broker has a consumer fetch message. ### Modifications When `kafkaTransactionCoordinatorEnabled = false`, ensure the transaction coordinator don't start. (cherry picked from commit 1415c6e)
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Feb 24, 2022
) Fixes streamnative#1090 ### Motivation Currently, even if we config kafkaTransactionCoordinatorEnabled=false, the Kafka transaction coordinator is still started. It happened when the broker has a consumer fetch message. ### Modifications When `kafkaTransactionCoordinatorEnabled = false`, ensure the transaction coordinator don't start. (cherry picked from commit 1415c6e)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1090
Motivation
Currently, even if we config kafkaTransactionCoordinatorEnabled=false, the Kafka transaction coordinator is still started.
It happened when the broker has a consumer fetch message.
Modifications
When
kafkaTransactionCoordinatorEnabled = false, ensure the transaction coordinator don't start.