This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[Authorization] List topic mapping to pulsar GET_TOPICS permission #1103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demogorgon314
requested review from
BewareMyPower and
jiazhai
as code owners
wenbingshen
suggested changes
Feb 22, 2022
Contributor
wenbingshen
left a comment
wenbingshen
left a comment
There was a problem hiding this comment.
Overall LGTM. Just left some minor comments. PTAL. :)
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaAuthorizationTestBase.java
Outdated
Show resolved
Hide resolved
BewareMyPower
suggested changes
Feb 22, 2022
tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaAuthorizationTestBase.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/io/streamnative/pulsar/handlers/kop/KafkaAuthorizationTestBase.java
Show resolved
Hide resolved
BewareMyPower
approved these changes
Feb 23, 2022
wenbingshen
approved these changes
Feb 23, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 25, 2022
…1103) Fixes #1068 ### Motivation Currently, we are using lookup to authorize the list topic permission, we should follow the pulsar way by using `validateNamespaceOperation(namespaceName, NamespaceOperation.GET_TOPICS);` to check the permission. ### Modifications List topic use pulsar GET_TOPICS permission (cherry picked from commit 5e7b674)
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 25, 2022
…1103) Fixes #1068 ### Motivation Currently, we are using lookup to authorize the list topic permission, we should follow the pulsar way by using `validateNamespaceOperation(namespaceName, NamespaceOperation.GET_TOPICS);` to check the permission. ### Modifications List topic use pulsar GET_TOPICS permission (cherry picked from commit 5e7b674)
BewareMyPower
pushed a commit
that referenced
this pull request
Feb 25, 2022
…1103) Fixes #1068 ### Motivation Currently, we are using lookup to authorize the list topic permission, we should follow the pulsar way by using `validateNamespaceOperation(namespaceName, NamespaceOperation.GET_TOPICS);` to check the permission. ### Modifications List topic use pulsar GET_TOPICS permission (cherry picked from commit 5e7b674)
michaeljmarshall
pushed a commit
to michaeljmarshall/kop
that referenced
this pull request
Dec 13, 2022
…treamnative#1103) Fixes streamnative#1068 Currently, we are using lookup to authorize the list topic permission, we should follow the pulsar way by using `validateNamespaceOperation(namespaceName, NamespaceOperation.GET_TOPICS);` to check the permission. List topic use pulsar GET_TOPICS permission (cherry picked from commit 5e7b674)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1068
Motivation
Currently, we are using lookup to authorize the list topic permission, we should follow the pulsar way by using
validateNamespaceOperation(namespaceName, NamespaceOperation.GET_TOPICS);to check the permission.Modifications
List topic use pulsar GET_TOPICS permission