This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Optimize the way to get the controllerId to branch-2.8.2 #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The tests might not be related to this PR, they also happened for branch-2.9.2, see https://github.com/streamnative/kop/runs/5331597530?check_suite_focus=true. @Demogorgon314 is investigating the failed tests currently. I'll rerun the test first. |
Member
|
The failed test was caused by apache/pulsar#12600, this PR changed behavior. Before this change, only tenant admin allow to list topic, after apache/pulsar#12600, it allows consume permission list topics. We should update the 2.8.2 and 2.9.2 branch's pulsar dependency first. 2.8.2 branch are using sn-pulsar v2.8.1.0 (should update to v2.8.2.0):2.9.2 branch are using sn-pulsar v2.9.0-rc-202110221101 (should update to v2.9.2.1): |
Collaborator
|
Could you rebase to branch-2.8.2? |
Contributor
Author
Addressed done. PTAL. Thanks. |
Demogorgon314
approved these changes
Feb 28, 2022
BewareMyPower
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title.