This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Handle duplicate topic names requests in MetadataRequest #1126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@BewareMyPower FYI |
BewareMyPower
approved these changes
Mar 2, 2022
Demogorgon314
approved these changes
Mar 2, 2022
BewareMyPower
pushed a commit
that referenced
this pull request
Mar 2, 2022
This is fix for a regression introduced by fbd91a8 This is the error I am seeing in a system test that uses KSQLDB. It refers to this line https://github.com/datastax/starlight-for-kafka/blob/a23423388ed5b476e3f30870370a066814cbd484/kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java#L678 > java.lang.IllegalStateException: Duplicate key persistent://public/default/_confluent-ksql-ktool_ksqldb__command_topic (attempted merging values _confluent-ksql-ktool_ksqldb__command_topic and _ (logs truncated.....) > at java.util.stream.Collectors.duplicateKeyException(Collectors.java:133) ~[?:?] > at java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1(Collectors.java:180) ~[?:?] > at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) ~[?:?] > at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655) ~[?:?] > at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?] > at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?] > at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) ~[?:?] > at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] > at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) ~[?:?] > at io.streamnative.pulsar.handlers.kop.KafkaRequestHandler.handleTopicMetadataRequest(KafkaRequestHandler.java:678) ~[4lTuHlI-OvogQpI9ZCLkuF8BmTtSg-BTfi4Po5ohsac/:?] │ > io.streamnative.pulsar.handlers.kop.KafkaCommandDecoder.channelRead(KafkaCommandDecoder.java:270) [4lTuHlI-OvogQpI9ZCLkuF8BmTtSg-BTfi4Po5ohsac/:?] │ > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [io.netty-netty-transport-4.1.74.Final.jar:4.1.74.Final] > (cherry picked from commit f198af6)
BewareMyPower
pushed a commit
that referenced
this pull request
Mar 2, 2022
This is fix for a regression introduced by fbd91a8 This is the error I am seeing in a system test that uses KSQLDB. It refers to this line https://github.com/datastax/starlight-for-kafka/blob/a23423388ed5b476e3f30870370a066814cbd484/kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java#L678 > java.lang.IllegalStateException: Duplicate key persistent://public/default/_confluent-ksql-ktool_ksqldb__command_topic (attempted merging values _confluent-ksql-ktool_ksqldb__command_topic and _ (logs truncated.....) > at java.util.stream.Collectors.duplicateKeyException(Collectors.java:133) ~[?:?] > at java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1(Collectors.java:180) ~[?:?] > at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) ~[?:?] > at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655) ~[?:?] > at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?] > at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?] > at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) ~[?:?] > at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] > at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) ~[?:?] > at io.streamnative.pulsar.handlers.kop.KafkaRequestHandler.handleTopicMetadataRequest(KafkaRequestHandler.java:678) ~[4lTuHlI-OvogQpI9ZCLkuF8BmTtSg-BTfi4Po5ohsac/:?] │ > io.streamnative.pulsar.handlers.kop.KafkaCommandDecoder.channelRead(KafkaCommandDecoder.java:270) [4lTuHlI-OvogQpI9ZCLkuF8BmTtSg-BTfi4Po5ohsac/:?] │ > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [io.netty-netty-transport-4.1.74.Final.jar:4.1.74.Final] > (cherry picked from commit f198af6)
Collaborator
|
This bug was introduced by #1107. Currently no releases are affected. |
BewareMyPower
pushed a commit
that referenced
this pull request
Mar 2, 2022
This is fix for a regression introduced by fbd91a8 This is the error I am seeing in a system test that uses KSQLDB. It refers to this line https://github.com/datastax/starlight-for-kafka/blob/a23423388ed5b476e3f30870370a066814cbd484/kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java#L678 > java.lang.IllegalStateException: Duplicate key persistent://public/default/_confluent-ksql-ktool_ksqldb__command_topic (attempted merging values _confluent-ksql-ktool_ksqldb__command_topic and _ (logs truncated.....) > at java.util.stream.Collectors.duplicateKeyException(Collectors.java:133) ~[?:?] > at java.util.stream.Collectors.lambda$uniqKeysMapAccumulator$1(Collectors.java:180) ~[?:?] > at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169) ~[?:?] > at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655) ~[?:?] > at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?] > at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?] > at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) ~[?:?] > at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?] > at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) ~[?:?] > at io.streamnative.pulsar.handlers.kop.KafkaRequestHandler.handleTopicMetadataRequest(KafkaRequestHandler.java:678) ~[4lTuHlI-OvogQpI9ZCLkuF8BmTtSg-BTfi4Po5ohsac/:?] │ > io.streamnative.pulsar.handlers.kop.KafkaCommandDecoder.channelRead(KafkaCommandDecoder.java:270) [4lTuHlI-OvogQpI9ZCLkuF8BmTtSg-BTfi4Po5ohsac/:?] │ > io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379) [io.netty-netty-transport-4.1.74.Final.jar:4.1.74.Final] > (cherry picked from commit f198af6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for a regression introduced by fbd91a8
This is the error I am seeing in a system test that uses KSQLDB.
It refers to this line https://github.com/datastax/starlight-for-kafka/blob/a23423388ed5b476e3f30870370a066814cbd484/kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java#L678