This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix NOT_COORDINATOR error caused by wrong brokers in Metadata response #1140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Motivation
After #1107 was cherry-picked into branch-2.8.2, some tests of
KafkaListenerNameTestare failed. Because that PR forgot to migrate the following code:kop/kafka-impl/src/main/java/io/streamnative/pulsar/handlers/kop/KafkaRequestHandler.java
Lines 792 to 796 in 51563fe
After that when the advertised listener is different with the listener, the brokers field in
MetadataResponsedoesn't contain the advertised listener, while the leader and ISR inMetadataResponse.PartitionMetadatause the advertised listener. Then Kafka client won't be able to find the advertised listener in brokers field.Modifications
Add the partition leader's node to the brokers field if the brokers field doesn't contain the node.