Skip to content
This repository was archived by the owner on Jan 24, 2024. It is now read-only.

Restore the support for Kafka clients 0.9 and 0.10 #1307

Merged
BewareMyPower merged 4 commits into from
May 30, 2022
Merged

Restore the support for Kafka clients 0.9 and 0.10 #1307

BewareMyPower merged 4 commits into from
May 30, 2022

Conversation

@Demogorgon314
Copy link
Member

@Demogorgon314 Demogorgon314 commented May 26, 2022 •
edited
Loading

Fixes: #1293

Motivation

#1060 updates the kafka-clients dependency to 2.1.1 but it drops the support for Kafka clients 0.9 and 0.10 because ListOffsetRequest.offsetData() method has removed.

Modifications

Add the old version of ListOffsetRequest to be compatible with Kafka clients 0.9 and 0.10.

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@Demogorgon314 Demogorgon314 self-assigned this May 26, 2022
@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 26, 2022
@eolivelli
Copy link
Contributor

eolivelli commented May 26, 2022

IIRC the main problem that was solved by #1060 is that older Kafka Clients bring well known CVEs inside the KOP package.
For that reason we had to drop it, otherwise KOP is not usable by enterprises that require 0 CVEs to run something in production.

This PR defeats the purpose of 1060.
I am not sure we can do this.

@nicoloboschi can you please confirm ?

@eolivelli
Copy link
Contributor

eolivelli commented May 26, 2022

an alternative approach is to copy/paste (or write from scratch) only the classes the we need

@Demogorgon314
Copy link
Member Author

Demogorgon314 commented May 26, 2022

@eolivelli Sure, I'll try to copy the necessary classes.

@Demogorgon314 Demogorgon314 changed the title Restore the support for Kafka clients 0.9 and 0.10 [WIP] Restore the support for Kafka clients 0.9 and 0.10 May 26, 2022
@Demogorgon314 Demogorgon314 changed the title [WIP] Restore the support for Kafka clients 0.9 and 0.10 Restore the support for Kafka clients 0.9 and 0.10 May 26, 2022
@Demogorgon314 Demogorgon314 marked this pull request as ready for review May 26, 2022 10:35
@Demogorgon314 Demogorgon314 requested review from a team, BewareMyPower and jiazhai as code owners May 26, 2022 10:35
@Demogorgon314 Demogorgon314 force-pushed the Demogorgon314/kop-issue-1293 branch from 88110ea to 43ed540 Compare May 26, 2022 11:20
eolivelli
eolivelli approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

great work

@BewareMyPower BewareMyPower merged commit 723d3be into streamnative:master May 30, 2022
BewareMyPower pushed a commit that referenced this pull request Jun 29, 2022
@Demogorgon314 @BewareMyPower
Restore the support for Kafka clients 0.9 and 0.10 (#1307)
ffba41c 
Fixes: #1293

### Motivation

#1060 updates the `kafka-clients` dependency to 2.1.1 but it drops the support for Kafka clients 0.9 and 0.10 because `ListOffsetRequest.offsetData()` method has removed.

### Modifications

Add the old version of `ListOffsetRequest` to be compatible with Kafka clients 0.9 and 0.10.

(cherry picked from commit 723d3be)
BewareMyPower added a commit that referenced this pull request Jun 29, 2022
@BewareMyPower
Revert "Restore the support for Kafka clients 0.9 and 0.10 (#1307)"
a203124 
This reverts commit ffba41c.
@woshihaoren
Copy link

woshihaoren commented Aug 24, 2022

@BewareMyPower why revert this pr ?
kop 2.10.6 can not work on 0.10.

@BewareMyPower
Copy link
Collaborator

BewareMyPower commented Aug 24, 2022

@woshihaoren Both this PR and #1060 are reverted. #1060 breaks the compatibility with 0.9 and 1.0 clients and this PR restores the compatibility. Since both them are reverted, 2.10.1.6 should still be compatible with 0.9 and 1.0 clients.

Could you open an issue to verify KoP 2.10.1.6 cannot work for Kafka 0.10 client?

@Demogorgon314 Demogorgon314 deleted the Demogorgon314/kop-issue-1293 branch October 14, 2022 15:09
michaeljmarshall pushed a commit to michaeljmarshall/kop that referenced this pull request Dec 13, 2022
@Demogorgon314 @eolivelli
Restore the support for Kafka clients 0.9 and 0.10 (streamnative#1307)
0e6516d 
Fixes: streamnative#1293

### Motivation

streamnative#1060 updates the `kafka-clients` dependency to 2.1.1 but it drops the support for Kafka clients 0.9 and 0.10 because `ListOffsetRequest.offsetData()` method has removed.

### Modifications

Add the old version of `ListOffsetRequest` to be compatible with Kafka clients 0.9 and 0.10.

(cherry picked from commit 723d3be)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jiazhai jiazhai Awaiting requested review from jiazhai

2 more reviewers

@eolivelli eolivelli eolivelli approved these changes

@BewareMyPower BewareMyPower BewareMyPower approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Demogorgon314 Demogorgon314

Labels

cherry-picked/branch-2.10.0 no-need-doc This pr does not need any document release/2.10.0 type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] Restore the support for Kafka clients 0.9 and 0.10

4 participants

@Demogorgon314 @eolivelli @woshihaoren @BewareMyPower