This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix the compatibility issue with Pulsar 2.11.0 #1734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`. It also fixes the bug that null values are not handled well for non-batched messages. This bug was exposed because of [PIP-189](apache/pulsar#16605). ### TODO Migrate the bug fix for non-batched messages to branch-2.10.x and branch-2.9.x.
BewareMyPower
force-pushed
the
bewaremypower/2.11-fix
branch
from
eadcac8 to
5914644
Compare
Codecov Report
@@ Coverage Diff @@
## master #1734 +/- ##
=========================================
Coverage 16.04% 16.04%
Complexity 625 625
=========================================
Files 165 165
Lines 12309 12308 -1
Branches 1127 1128 +1
=========================================
Hits 1975 1975
+ Misses 10170 10169 -1
Partials 164 164
|
Demogorgon314
approved these changes
Feb 22, 2023
Demogorgon314
pushed a commit
that referenced
this pull request
Feb 22, 2023
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`. It also fixes the bug that null values are not handled well for non-batched messages. This bug was exposed because of [PIP-189](apache/pulsar#16605). (cherry picked from commit 88fe870)
eolivelli
pushed a commit
to eolivelli/kop
that referenced
this pull request
Feb 28, 2023
### Motivation apache/pulsar#17696 removes the `powermock-reflect` dependency, which leads to a compilation error in KoP. ### Modifications Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace `Whitebox.invokeMethod` with `MethodUtils.invokeMethod`. It also fixes the bug that null values are not handled well for non-batched messages. This bug was exposed because of [PIP-189](apache/pulsar#16605).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
apache/pulsar#17696 removes the
powermock-reflectdependency, which leads to a compilation error inKoP.
Modifications
Upgrade the Pulsar dependency to 2.11.0.0-rc5. Then replace
Whitebox.invokeMethodwithMethodUtils.invokeMethod.It also fixes the bug that null values are not handled well for
non-batched messages. This bug was exposed because of
PIP-189.
TODO
Migrate the bug fix for non-batched messages to branch-2.10.x and
branch-2.9.x.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)