This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix usage of Pulsar's AuthenticationState object#1824
Closed
eolivelli wants to merge 1 commit intostreamnative:masterfrom
Closed
Fix usage of Pulsar's AuthenticationState object#1824eolivelli wants to merge 1 commit intostreamnative:masterfrom
eolivelli wants to merge 1 commit intostreamnative:masterfrom
Conversation
(cherry picked from commit 4125c258311ce208bf959764c3bee50f3ba31fe0)
Collaborator
|
I think we don't need to migrate this fix from datastax/starlight-for-kafka#85. From the description:
KoP depends on the 3.0.0 release candidate, which already contains the asynchronous authentication changes. This issue seems only related to the dependency of s4k. |
Contributor
Author
|
@BewareMyPower you are right. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original patch was written by @michaeljmarshall here
Motivation
There is a breaking API change in upcoming Pulsar versions:
apache/pulsar#19295
This patch allows KOP to run on newer Pulsar versions.
Modifications
Use the authenticate() method instead of authenticateAsync()
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Documentation
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)