This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix flaky OffsetTopicWriteTimeoutTest#1914
Merged
BewareMyPower merged 2 commits intostreamnative:masterfrom Jun 27, 2023
Merged
Fix flaky OffsetTopicWriteTimeoutTest#1914BewareMyPower merged 2 commits intostreamnative:masterfrom
BewareMyPower merged 2 commits intostreamnative:masterfrom
Conversation
### Motivation Even if the session timeout is only 1ms, there is still a chance that the write does not time out. ### Modifications Run each test in `OffsetTopicWriteTimeoutTest` 10 times and check the errors could only be the expected error or just `NONE`.
Codecov Report
@@ Coverage Diff @@
## master #1914 +/- ##
=========================================
Coverage 18.64% 18.64%
Complexity 743 743
=========================================
Files 186 186
Lines 13377 13377
Branches 1231 1231
=========================================
Hits 2494 2494
Misses 10702 10702
Partials 181 181 |
4 tasks
Demogorgon314
approved these changes
Jun 27, 2023
BewareMyPower
added a commit
that referenced
this pull request
Jun 29, 2023
### Motivation Even if the session timeout is only 1ms, there is still a chance that the write does not time out. ### Modifications Run each test in `OffsetTopicWriteTimeoutTest` 10 times and check the errors could only be the expected error or just `NONE`. (cherry picked from commit dfb3285)
BewareMyPower
added a commit
that referenced
this pull request
Jul 3, 2023
### Motivation Even if the session timeout is only 1ms, there is still a chance that the write does not time out. ### Modifications Run each test in `OffsetTopicWriteTimeoutTest` 10 times and check the errors could only be the expected error or just `NONE`. (cherry picked from commit dfb3285)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Aug 14, 2023
### Motivation Even if the session timeout is only 1ms, there is still a chance that the write does not time out. ### Modifications Run each test in `OffsetTopicWriteTimeoutTest` 10 times and check the errors could only be the expected error or just `NONE`. (cherry picked from commit dfb3285)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Even if the session timeout is only 1ms, there is still a chance that the write does not time out.
Modifications
Run each test in
OffsetTopicWriteTimeoutTest10 times and check the errors could only be the expected error or justNONE.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)