This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[branch-2.11] Fix failed GroupMetadataManagerTest#1934
Merged
Demogorgon314 merged 1 commit intobranch-2.11from Jul 2, 2023
Merged
[branch-2.11] Fix failed GroupMetadataManagerTest#1934Demogorgon314 merged 1 commit intobranch-2.11from
Demogorgon314 merged 1 commit intobranch-2.11from
Conversation
### Motivation When running `GroupMetadataManagerTest`, `testOffsetWriteAfterGroupRemoved` will be called after `testOffsetTopicNumPartitionsModify`, which changes the `offsetTopicNumPartitions` to 100 so that `consumerGroupPartitionId` will be 74 while `groupPartitionId` is 0, and then the group metadata will be sent to partition 0 while `scheduleLoadGroupAndOffsets` will read from partition 74. Since no group metadata is loaded, ### Modifications Migrate the fix in #1759 to reset the `offsetTopicNumPartitions` before and after each method.
Codecov Report
@@ Coverage Diff @@
## branch-2.11 #1934 +/- ##
=================================================
- Coverage 18.37% 18.11% -0.27%
Complexity 707 707
=================================================
Files 173 178 +5
Lines 13065 13301 +236
Branches 1195 1232 +37
=================================================
+ Hits 2401 2409 +8
- Misses 10495 10721 +226
- Partials 169 171 +2
|
Demogorgon314
approved these changes
Jul 2, 2023
Demogorgon314
deleted the
bewaremypower/branch-2.11-fix-group-metadata-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When running
GroupMetadataManagerTest,testOffsetWriteAfterGroupRemovedwill be called aftertestOffsetTopicNumPartitionsModify, which changes theoffsetTopicNumPartitionsto 100 so thatconsumerGroupPartitionIdwill be 74 whilegroupPartitionIdis 0, and then the group metadata will be sent to partition 0 whilescheduleLoadGroupAndOffsetswill read from partition 74. Since no group metadata is loaded,Modifications
Migrate the fix in #1759 to reset the
offsetTopicNumPartitionsbefore and after each method.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)