This repository was archived by the owner on Jan 24, 2024. It is now read-only.
[CI] Upload surefire artifacts when tests failed#1989
Merged
BewareMyPower merged 2 commits intostreamnative:masterfrom Aug 1, 2023
Merged
[CI] Upload surefire artifacts when tests failed#1989BewareMyPower merged 2 commits intostreamnative:masterfrom
BewareMyPower merged 2 commits intostreamnative:masterfrom
Conversation
### Motivation After streamnative#1925, the surefire artifacts won't be uploaded if tests failed. ### Modifications Upload the surefire artifacts when tests failed.
gaoran10
previously approved these changes
Aug 1, 2023
Collaborator
Author
|
@Demogorgon314 I used different artifacts names now, PTAL again. |
Codecov Report
@@ Coverage Diff @@
## master #1989 +/- ##
============================================
- Coverage 17.72% 17.28% -0.44%
+ Complexity 751 726 -25
============================================
Files 195 190 -5
Lines 14156 14012 -144
Branches 1322 1312 -10
============================================
- Hits 2509 2422 -87
+ Misses 11464 11414 -50
+ Partials 183 176 -7
|
Demogorgon314
approved these changes
Aug 1, 2023
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Aug 14, 2023
### Motivation After streamnative#1925, the surefire artifacts won't be uploaded if tests failed. ### Modifications Upload the surefire artifacts when tests failed. (cherry picked from commit bdcb731)
Demogorgon314
pushed a commit
to Demogorgon314/kop
that referenced
this pull request
Nov 28, 2023
### Motivation After streamnative#1925, the surefire artifacts won't be uploaded if tests failed. ### Modifications Upload the surefire artifacts when tests failed. (cherry picked from commit bdcb731) (cherry picked from commit e24e767)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After #1925, the surefire artifacts won't be uploaded if tests failed.
Modifications
Upload the surefire artifacts when tests failed.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)