This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fix the regression for https://github.com/streamnative/kop/pull/1749#2024
Merged
BewareMyPower merged 1 commit intostreamnative:masterfrom Oct 31, 2023
Conversation
### Motivation streamnative#1923 removes the completion for the produce purgatory in streamnative#1749. ### Modification Added back the logic to check and complete the produce purgatory.
Demogorgon314
approved these changes
Oct 31, 2023
Codecov Report
@@ Coverage Diff @@
## master #2024 +/- ##
============================================
- Coverage 16.98% 16.96% -0.02%
+ Complexity 730 729 -1
============================================
Files 191 191
Lines 14309 14310 +1
Branches 1339 1339
============================================
- Hits 2430 2428 -2
- Misses 11703 11705 +2
- Partials 176 177 +1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#1923 removes the completion for the produce purgatory in #1749.
Modification
Added back the logic to check and complete the produce purgatory.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)