This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Support CreateTopics request#244
Merged
jiazhai merged 5 commits intostreamnative:masterfrom Dec 1, 2020
Merged
Conversation
4 tasks
Collaborator
Author
|
I'll resolve the conflict soon. |
BewareMyPower
force-pushed
the
bewaremypower/support-create-topic
branch
from
cdb88e4 to
34d6370
Compare
Collaborator
Author
|
Now the conflict is resolved, PTAL @jiazhai |
jiazhai
approved these changes
Dec 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master issue: #241
This PR add support for Kafka
CreateTopicsrequest so that topics can be created by Kafka'sAdminClient. Related tests are added to verifyThe
validateOnlyfield introduced fromCreateTopicsrequest v1 is not processed. ThevalidateOnlyfield only checks the topics can be created as specified but not creates anything. It's not a important feature currently so leave it as a future task.