This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Fill the offset field of PartitionResponse#245
Merged
jiazhai merged 2 commits intostreamnative:masterfrom Nov 30, 2020
Merged
Conversation
jiazhai
approved these changes
Nov 30, 2020
jiazhai
approved these changes
Nov 30, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #230
Master issue: #241
The offset field is not filled when a PRODUCE request is processed yet. It causes that the offset what Kafka producer get from
send()'s callback is always -1, which may cause some problems like #241 mentioned.This PR fills the offset field and add a unit test to verify if the right offset is set.